Skip to content

Remove WordPress widget and iOS 13 Today widget related code - #21521

Merged
staskus merged 5 commits into
trunkfrom
task/21519-remove-unnecessary-code
Sep 8, 2023
Merged

Remove WordPress widget and iOS 13 Today widget related code#21521
staskus merged 5 commits into
trunkfrom
task/21519-remove-unnecessary-code

Conversation

@staskus

@staskus staskus commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

Fixes #21519

Description

WordPress widget-related removals

  • Removing WordPressStatsWidgets target, since we no longer support widgets on the WordPress app
  • Removing WordPressIntents target, it's used for selecting a site for a widget - Initial changes to make the Today Home Widget customizable. #15397
  • Removing target related code from Podfile
  • Removing target related code from Fastfile
  • Renaming WordPressStatsWidgets and WordPressIntents folders to JetpackStatsWidgets and JetpackIntents, updating places where the names are referenced (I looked for occurrences with grep)

iOS 13 widget-related removals

Targets and some of the code was removed with #19509, however, some of the code was still in the codebase and it created confusion whether it referenced iOS14 or iOS13 widgets

  • Removing constants
  • Removing stats and site information saving logic (iOS 14 widgets use different logic)
  • Removing Today extension-related code

To test:

  1. Open Jetpack
  2. Login
  3. Go to home screen, long tap, and select Jetpack
  4. Add widget
  5. Confirm information appears for a site
  6. Long-hold widget
  7. Confirm site can be changed
  8. Change the site
  9. Confirm that the data loads

Regression Notes

  1. Potential unintended areas of impact

Breaking current widget behavior, breaking fastlane flows, breaking localization flows

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing, CI, and code-reviews

  1. What automated tests I added (or what prevented me from doing so)

None

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@staskus staskus added [Type] Enhancement Widgets Anything related to Home Screen widgets labels Sep 7, 2023
@staskus staskus added this to the 23.3 milestone Sep 7, 2023
@staskus
staskus requested a review from guarani September 7, 2023 14:03
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Sep 7, 2023

Copy link
Copy Markdown
Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@wpmobilebot

wpmobilebot commented Sep 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21521-0da1d27
Version23.2
Bundle IDorg.wordpress.alpha
Commit0da1d27
App Center BuildWPiOS - One-Offs #6989
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot

wpmobilebot commented Sep 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21521-0da1d27
Version23.2
Bundle IDcom.jetpack.alpha
Commit0da1d27
App Center Buildjetpack-installable-builds #6031
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

guarani
guarani approved these changes Sep 8, 2023
View reviewed changes

@guarani guarani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing all @staskus!

I think we could remove isJetpack checks at some point. Also, I'm not sure if userDefaultsJetpackFeaturesDisabledKey is needed anymore unless it's used for sites without Stats (e.g. self-hosted). Either way, this might need further investigation but isn't a blocker here.

Comment thread WordPress/Jetpack/WidgetConfiguration.swift
@staskus
staskus enabled auto-merge September 8, 2023 07:02
@staskus
staskus merged commit c8ae133 into trunk Sep 8, 2023
@staskus
staskus deleted the task/21519-remove-unnecessary-code branch September 8, 2023 08:28
@staskus staskus mentioned this pull request Sep 8, 2023
Merged
4 tasks
crazytonyli added a commit that referenced this pull request Oct 15, 2023
@crazytonyli
Remove an unused source file: LocalizationConfiguration.swift
36ca389 
This file is not used in any target. Also, it seems to be a duplication of
WordPress/JetpackStatsWidgets/LocalizationConfiguration.swift. It's
potentially a left-over from #21521.
@crazytonyli crazytonyli mentioned this pull request Oct 15, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@guarani guarani guarani approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Widgets Anything related to Home Screen widgets

Projects

None yet

Milestone

23.3

Development

Successfully merging this pull request may close these issues.

Lock Screen Widgets: Remove WordPress widget and iOS13 widget code

3 participants

@staskus @wpmobilebot @guarani